Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: cleanup util #25255

Closed
wants to merge 5 commits into from
Closed

util: cleanup util #25255

wants to merge 5 commits into from

Conversation

BridgeAR
Copy link
Member

Just some cleanup while trying to figure out some other things.

Please have a look at the commit messages for details.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
util: switch recurseTimes counter
17aa99f 
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.
@BridgeAR
util: code cleanup
e73a36c 
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.
@BridgeAR
util: simpler module namespace code
65cad90 
This removes a special casing for this data type in the main function.
@BridgeAR
util: remove outdated comment
057882e 
This comment is not correct anymore.
@BridgeAR
util: remove eslint comments and rename variables
669c2f4 
This should improve the readability of the code.
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2093/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 28, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

@nodejs/util PTAL

This is open for quite some while without getting any reviews.

@BridgeAR
Copy link
Member Author

BridgeAR commented Jan 9, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/20029/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019
@BridgeAR
Copy link
Member Author

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/20043/

@danbev
Copy link
Contributor

danbev commented Jan 11, 2019

Landed in eca2760, 76fa37a, 1ab659a, 1bee544, 6cc74b0.

@danbev danbev closed this Jan 11, 2019
danbev pushed a commit that referenced this pull request Jan 11, 2019
@BridgeAR @danbev
util: switch recurseTimes counter
eca2760 
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit that referenced this pull request Jan 11, 2019
@BridgeAR @danbev
util: code cleanup
76fa37a 
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit that referenced this pull request Jan 11, 2019
@BridgeAR @danbev
util: simpler module namespace code
1ab659a 
This removes a special casing for this data type in the main function.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit that referenced this pull request Jan 11, 2019
@BridgeAR @danbev
util: remove outdated comment
1bee544 
This comment is not correct anymore.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit that referenced this pull request Jan 11, 2019
@BridgeAR @danbev
util: remove eslint comments and rename variables
6cc74b0 
This should improve the readability of the code.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
util: switch recurseTimes counter
7696d1f 
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
util: code cleanup
a333272 
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
util: simpler module namespace code
45a8eb6 
This removes a special casing for this data type in the main function.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
util: remove outdated comment
7ff4410 
This comment is not correct anymore.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@BridgeAR @addaleax
util: remove eslint comments and rename variables
46ec26f 
This should improve the readability of the code.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
util: switch recurseTimes counter
c7cffca 
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
util: code cleanup
5db3228 
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
util: simpler module namespace code
57ae88b 
This removes a special casing for this data type in the main function.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
util: remove outdated comment
e913996 
This comment is not correct anymore.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
util: remove eslint comments and rename variables
6c9fd71 
This should improve the readability of the code.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@BridgeAR BridgeAR deleted the cleanup-util branch January 20, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @nodejs-github-bot @danbev @jasnell