src: remove redundant if block #25304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
mscdex
reviewed
Jan 1, 2019
src/node.cc
Outdated
| return; | ||
| } | ||
| ExecuteBootstrapper( | ||
| env, "internal/bootstrap/node", &node_params, &node_args); |
There was a problem hiding this comment.
I think this can all fit on one line now?
There was a problem hiding this comment.
@mscdex Thank you for pointing that out. I updated PR.
`void LoadEnvironment(Environment* env)` had a redundant if block at the end of the function.
kkty
force-pushed
the
remove-redundant-if-block
branch
from
a15ff06
to
97a22a9
Compare
jasnell
approved these changes
Jan 1, 2019
fhinkel
approved these changes
Jan 5, 2019
lpinca
approved these changes
Jan 5, 2019
|
@kkty This would need a rebase, but I’m not sure that it still applies to the current code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void LoadEnvironment(Environment* env)had a redundant if block atthe end of the function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes