Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean up wasm fixtures #25360

Merged
merged 1 commit into from
Jan 8, 2019
Merged

test: clean up wasm fixtures #25360

merged 1 commit into from
Jan 8, 2019

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jan 6, 2019 •
edited
Loading

This just renames the wasm fixtures and adds some comments to their wat sources.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@devsnek devsnek added test Issues and PRs related to the tests. wasm Issues and PRs related to WebAssembly. labels Jan 6, 2019
@devsnek devsnek requested a review from addaleax January 6, 2019 01:00
@nodejs-github-bot
Copy link
Collaborator

@devsnek build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2148/pipeline

@devsnek
Copy link
Member Author

devsnek commented Jan 6, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/19949/

@devsnek devsnek added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2019
@devsnek
test: clean up wasm fixtures
0c8dedd 
PR-URL: nodejs#25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@devsnek
Copy link
Member Author

devsnek commented Jan 8, 2019

landed in 0c8dedd

@devsnek devsnek merged commit 0c8dedd into nodejs:master Jan 8, 2019
@devsnek devsnek deleted the refactor/test-wasm branch January 8, 2019 19:00
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@devsnek @addaleax
test: clean up wasm fixtures
c826af7 
PR-URL: #25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@devsnek @BridgeAR
test: clean up wasm fixtures
e76b4b0 
PR-URL: nodejs#25360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. wasm Issues and PRs related to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devsnek @nodejs-github-bot @addaleax @cjihrig