test: fix test-benchmark-zlib #25365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification.
|
node-daily-master will fail until this change lands, so please 👍 here to fast-track. |
2 tasks
cjihrig
approved these changes
Jan 6, 2019
jasnell
approved these changes
Jan 6, 2019
lpinca
approved these changes
Jan 6, 2019
|
Landed in 6f27f53 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 6, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: nodejs#25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: #25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: nodejs#25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: nodejs#25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: #25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: #25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
The addition of brotli to zlib benchmarks means that test-benchmark-zlib needs to be modified. This is that modification. PR-URL: #25365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes