Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: initialize Environment members in class definition #25369

Closed
wants to merge 1 commit into from
Closed

src: initialize Environment members in class definition #25369

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 6, 2019

Initialize primitive members of Environment in the class definition for clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: initialize Environment members in class definition
dd6a014 
Initialize primitive members of `Environment` in the class definition
for clarity.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2156/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 6, 2019
@danbev
Copy link
Contributor

danbev commented Jan 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/19960/

@addaleax
Copy link
Member Author

addaleax commented Jan 7, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19984/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2019
@addaleax
Copy link
Member Author

addaleax commented Jan 8, 2019

Landed in 8d893f2

@addaleax addaleax closed this Jan 8, 2019
@addaleax addaleax deleted the init-prim branch January 8, 2019 23:47
addaleax added a commit that referenced this pull request Jan 8, 2019
@addaleax
src: initialize Environment members in class definition
8d893f2 
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: #25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
@addaleax
src: initialize Environment members in class definition
d1ff107 
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: #25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@addaleax @BridgeAR
src: initialize Environment members in class definition
197eaac 
Initialize primitive members of `Environment` in the class definition
for clarity.

PR-URL: nodejs#25369
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@JungMinu JungMinu JungMinu approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @nodejs-github-bot @danbev @jasnell @lpinca @cjihrig @mmarchini @JungMinu @richardlau