Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix section order in vm.md #25374

Closed
wants to merge 1 commit into from
Closed

doc: fix section order in vm.md #25374

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

This PR just places the vm.SourceTextModule class section after the vm.Script class section, restoring the alphabetical order.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jan 7, 2019
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.
@vsemozhetbyt
Copy link
Contributor Author

Rebased. Diff is a bit messed up this time.
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2239/

@danbev
Copy link
Contributor

danbev commented Jan 14, 2019

Landed in 0e1cf1e.

@danbev danbev closed this Jan 14, 2019
danbev pushed a commit that referenced this pull request Jan 14, 2019
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: #25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-vm-sort branch January 14, 2019 08:47
addaleax pushed a commit that referenced this pull request Jan 14, 2019
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: #25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
This PR just places the `vm.SourceTextModule` class section
after the `vm.Script` class section, restoring the alphabetical order.

PR-URL: nodejs#25374
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants