Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: changed function to arrow function #25441

Closed
wants to merge 2 commits into from
Closed

test: changed function to arrow function #25441

wants to merge 2 commits into from

Conversation

yathamravali
Copy link

This is my first pr.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 11, 2019
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20074/

@gireeshpunathil
Copy link
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25009/

@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-commit/25036/

@danbev
Copy link
Contributor

danbev commented Jan 15, 2019

Re-run of failing node-test-commit-arm

This was referenced Jan 16, 2019
Closed
Closed
Closed
@gireeshpunathil
Copy link
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25182/

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2019
@gireeshpunathil
Copy link
Member

landed as 27871c3 , thanks!

gireeshpunathil pushed a commit that referenced this pull request Jan 21, 2019
@gireeshpunathil
test: changed function to arrow function
27871c3 
PR-URL: #25441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil gireeshpunathil removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2019
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@addaleax
test: changed function to arrow function
5684da5 
PR-URL: #25441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@BethGriggs
test: changed function to arrow function
f76c8df 
PR-URL: #25441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@BethGriggs
test: changed function to arrow function
463b6e5 
PR-URL: #25441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@MylesBorins
test: changed function to arrow function
faf1a18 
PR-URL: #25441
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yathamravali @addaleax @gireeshpunathil @danbev @jasnell @cjihrig @nodejs-github-bot