src: reduce includes of node_internals.h #25507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joyeecheung sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
c++
danbev
approved these changes
Jan 15, 2019
bnoordhuis
approved these changes
Jan 15, 2019
| #include <sstream> | ||
| #include <string> | ||
| #include "async_wrap.h" | ||
| #include "env-inl.h" |
There was a problem hiding this comment.
Style: own headers before system headers.
(Well, style... it's to avoid accidental dependencies on system headers in our own headers)
| #include <string> | ||
| #include "util.h" |
src/string_search.h
Outdated
| #include <string.h> | ||
| #include <algorithm> | ||
| #include "util.h" |
cjihrig
approved these changes
Jan 15, 2019
addaleax
approved these changes
Jan 15, 2019
joyeecheung
added
the
author ready
This was referenced Jan 16, 2019
|
@joyeecheung You added the author-ready label but did you address the feedback? |
joyeecheung
force-pushed
the
reduce-internals
branch
from
dcded4c
to
e1d0070
Compare
|
@bnoordhuis Looks like my push did not succeed (GFW hiccups). Addressed the reviews and rebased. |
jasnell
approved these changes
Jan 18, 2019
joyeecheung
force-pushed
the
reduce-internals
branch
from
f2c4aeb
to
fa6fd18
Compare
|
Added an additional hack for https://ci.nodejs.org/job/node-test-pull-request/20206/ (✔️) |
|
Landed in 1838d00. |
danbev
pushed a commit
that referenced
this pull request
Jan 21, 2019
PR-URL: #25507 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25507 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
node_internals.hserves as a header for declarationsof internal APIs that do not have their own headers, so it includes
many other headers for internal types and is subject to frequent
changes, which often trigger recompilations of files that
include
node_internals.hand creates a lot of indirect dependencieson unnecessary headers.
This patch moves the utilities in
node_internals.hthatonly depends on
v8.hintoutil.h, and reduce the number of includesof
node_internals.hacross the code base - most of them can bereplaced with
util.horenv-inl.hinstead.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes