Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct my wrong note about buf.fill() #25585

Closed
wants to merge 1 commit into from
Closed

doc: correct my wrong note about buf.fill() #25585

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 19, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, I've misinterpreted this operation:

node/src/node_buffer.cc

Line 566 in c1ac578

int value = val & 255; 

> Buffer.alloc(5).fill(255)
<Buffer ff ff ff ff ff>
> Buffer.alloc(5).fill(256)
<Buffer 00 00 00 00 00>
> Buffer.alloc(5).fill(257)
<Buffer 01 01 01 01 01>
> Buffer.alloc(5).fill(258)
<Buffer 02 02 02 02 02>

@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2302/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jan 19, 2019
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jan 19, 2019
Closed
3 tasks
@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 20, 2019
vsemozhetbyt added a commit that referenced this pull request Jan 20, 2019
@vsemozhetbyt
doc: correct my wrong note about buf.fill()
17c6b1d 
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 17c6b1d
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-del-buf-fill-255 branch January 20, 2019 15:06
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@vsemozhetbyt @addaleax
doc: correct my wrong note about buf.fill()
0c046e8 
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@vsemozhetbyt @BethGriggs
doc: correct my wrong note about buf.fill()
8d309dc 
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@vsemozhetbyt @BethGriggs
doc: correct my wrong note about buf.fill()
eb3b516 
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@vsemozhetbyt @MylesBorins
doc: correct my wrong note about buf.fill()
13205d5 
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @nodejs-github-bot @ChALkeR @addaleax @lpinca