Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x-backport] n-api: mark thread-safe function as stable #25633

Closed
wants to merge 1 commit into from
Closed

[v10.x-backport] n-api: mark thread-safe function as stable #25633

wants to merge 1 commit into from
+30 −26

Conversation

gabrielschulhof
Copy link
Contributor

Fixes: #24249
PR-URL: #25556

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2336/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Jan 22, 2019
@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from fe2664a to 96a21ea Compare January 22, 2019 07:38
mhdawson
mhdawson approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof gabrielschulhof added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 22, 2019
@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 96a21ea to 23a9bda Compare January 25, 2019 19:24
@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20325/

@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 23a9bda to 3a265b0 Compare January 25, 2019 20:30
@gabrielschulhof
Copy link
Contributor Author

Whoops! New CI: https://ci.nodejs.org/job/node-test-pull-request/20334/

@gabrielschulhof
Copy link
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/20337/

@gabrielschulhof
Copy link
Contributor Author

Another resume: https://ci.nodejs.org/job/node-test-pull-request/20343/

@gabrielschulhof
Copy link
Contributor Author

...and another resume: https://ci.nodejs.org/job/node-test-pull-request/20367/

@gabrielschulhof
Copy link
Contributor Author

OK, so it looks like we dropped support for FreeBSD 10, but if I am to backport this to to v10.x, I need it to build on FreeBSD 10. Right now it looks like it's failing for an unrelated reason, but I suspect it's part of the reason why we dropped support for FreeBSD 10.

@gabrielschulhof
Copy link
Contributor Author

I ran a job against acf7e7d which is already on v10.x-staging and it also fails the same way: https://ci.nodejs.org/job/node-test-commit-freebsd/23660/

@gabrielschulhof gabrielschulhof mentioned this pull request Jan 28, 2019
Closed
@gabrielschulhof
Copy link
Contributor Author

Now running a job against the commit previous to acf7e7d: https://ci.nodejs.org/job/node-test-commit-freebsd/23677/

@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 3a265b0 to 5380f48 Compare January 29, 2019 06:04
@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 5380f48 to 9ced725 Compare January 29, 2019 06:17
@gabrielschulhof
Copy link
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/20400/

@codebytere codebytere force-pushed the v10.x-staging branch 2 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12
n-api: mark thread-safe function as stable
cff27fe 
Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 9ced725 to cff27fe Compare January 29, 2019 19:19
@gabrielschulhof
Copy link
Contributor Author

New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/20419 (pending as of this writing)

@gabrielschulhof
Copy link
Contributor Author

Resumed as https://ci.nodejs.org/job/node-test-pull-request/20421 (also pending) because the previous one did not seem to run.

@gabrielschulhof
Copy link
Contributor Author

Trying again with https://ci.nodejs.org/job/node-test-pull-request/20424.

@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Jan 30, 2019 •
edited
Loading

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/20438/ ✔️

@gabrielschulhof gabrielschulhof mentioned this pull request Feb 21, 2019
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Mar 4, 2019
n-api: mark thread-safe function as stable
ad9c154 
Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/21341/

BethGriggs pushed a commit that referenced this pull request Mar 12, 2019
@BethGriggs
n-api: mark thread-safe function as stable
48a5241 
Fixes: #24249
PR-URL: #25556
Backport-PR-URL: #25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs
Copy link
Member

Landed in 48a5241

@BethGriggs BethGriggs closed this Mar 12, 2019
richardlau added a commit to richardlau/node-1 that referenced this pull request May 23, 2019
@richardlau
doc,n-api: update matrix for N-API version 4
805f40f 
The N-API version was bumped to 4 for Node.js 10 in
nodejs#25633

Refs: nodejs#25633
@richardlau richardlau mentioned this pull request May 23, 2019
Closed
3 tasks
BethGriggs pushed a commit that referenced this pull request May 28, 2019
@richardlau @BethGriggs
doc,n-api: update matrix for N-API version 4
1ae6853 
The N-API version was bumped to 4 for Node.js 10 in
#25633

Refs: #25633
BethGriggs pushed a commit that referenced this pull request May 28, 2019
@richardlau @BethGriggs
doc,n-api: update matrix for N-API version 4
99e969e 
The N-API version was bumped to 4 for Node.js 10 in
#25633

Refs: #25633

PR-URL: #27832
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof deleted the un-experimental-tsfn-v10.x branch June 14, 2019 23:51
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @nodejs-github-bot @BethGriggs @mhdawson