n-api: change #ifdef to #if in node_api_types #25635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are a number of compiler warnings like the following: In file included from ../src/node_api.h:11: ../src/node_api_types.h:13:21:x warning: extra tokens at end of #ifdef directive [-Wextra-tokens] #ifdef NAPI_VERSION >= 4 This commit changes the #ifdef macros to #if.
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Jan 22, 2019
cjihrig
approved these changes
Jan 22, 2019
richardlau
approved these changes
Jan 22, 2019
addaleax
approved these changes
Jan 22, 2019
|
Landed in b070c99. |
danbev
added a commit
that referenced
this pull request
Jan 23, 2019
Currently, there are a number of compiler warnings like the following: In file included from ../src/node_api.h:11: ../src/node_api_types.h:13:21:x warning: extra tokens at end of #ifdef directive [-Wextra-tokens] #ifdef NAPI_VERSION >= 4 This commit changes the #ifdef macros to #if. PR-URL: #25635 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jan 24, 2019
Currently, there are a number of compiler warnings like the following: In file included from ../src/node_api.h:11: ../src/node_api_types.h:13:21:x warning: extra tokens at end of #ifdef directive [-Wextra-tokens] #ifdef NAPI_VERSION >= 4 This commit changes the #ifdef macros to #if. PR-URL: #25635 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are a number of compiler warnings like the following:
This commit changes the
#ifdefmacros to#if.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes