Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: stop using v8::Function in node_os.cc #25640

Merged
merged 1 commit into from
Jan 24, 2019
Merged

src: stop using v8::Function in node_os.cc #25640

merged 1 commit into from
Jan 24, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 22, 2019

It is unused in the file.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2340/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Jan 22, 2019
lundibundi
lundibundi approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Though I'd prefer to rename the commit to something like src: remove using v8::Function statement from node_os.cc to be a bit more clear.

mhdawson
mhdawson approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 22, 2019

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/20260/

@cjihrig
src: remove using v8::Function in node_os.cc
d40ed71 
PR-URL: nodejs#25640
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@cjihrig cjihrig merged commit d40ed71 into nodejs:master Jan 24, 2019
@cjihrig cjihrig deleted the using branch January 24, 2019 13:34
targos pushed a commit that referenced this pull request Jan 24, 2019
@cjihrig @targos
src: remove using v8::Function in node_os.cc
c59edca 
PR-URL: #25640
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lundibundi lundibundi lundibundi approved these changes

@richardlau richardlau richardlau approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @addaleax @TimothyGu @richardlau @lundibundi @mhdawson