Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: clean up GC listeners #25647

Closed
wants to merge 1 commit into from
Closed

perf_hooks: clean up GC listeners #25647

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Add Environment cleanup hooks to remove GC listeners when the Environment is torn down.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
perf_hooks: clean up GC listeners
a5d8c15 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2344/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 22, 2019
@addaleax addaleax added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Jan 22, 2019
@addaleax addaleax mentioned this pull request Jan 22, 2019
Closed
4 tasks
@addaleax
Copy link
Member Author

This needs another review (maybe @jasnell)?

CI: https://ci.nodejs.org/job/node-test-pull-request/20301/

@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20350/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2019
@addaleax
Copy link
Member Author

Rebuild: https://ci.nodejs.org/job/node-test-pull-request/20354/

@addaleax
Copy link
Member Author

Landed in acc5a86

@addaleax addaleax closed this Jan 28, 2019
@addaleax addaleax deleted the perf-env-listeners branch January 28, 2019 00:45
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
perf_hooks: clean up GC listeners
acc5a86 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
perf_hooks: clean up GC listeners
fc38b20 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
brenca pushed a commit to electron/node that referenced this pull request Mar 5, 2019
@addaleax @brenca
perf_hooks: clean up GC listeners
d2bb4b9 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit to electron/node that referenced this pull request Mar 5, 2019
@brenca @codebytere
perf_hooks: clean up GC listeners (#94)
f807d72 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Mar 18, 2019
Closed
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
ceebcb8 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
bd34d5c 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nitsakh pushed a commit to electron/node that referenced this pull request Mar 18, 2019
@brenca @nitsakh
perf_hooks: clean up GC listeners (#94)
e05e320 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: nodejs/node#25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@addaleax @BethGriggs
perf_hooks: clean up GC listeners
9558901 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@addaleax @BethGriggs
perf_hooks: clean up GC listeners
b04c219 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
perf_hooks: clean up GC listeners
ff3d977 
Add Environment cleanup hooks to remove GC listeners when the
`Environment` is torn down.

PR-URL: #25647
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@beevelop beevelop mentioned this pull request May 29, 2019
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @joyeecheung @richardlau