Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-*-ci-reneg-attack.js #25660

Closed
wants to merge 1 commit into from
Closed

test: refactor test-*-ci-reneg-attack.js #25660

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 23, 2019

Refactor test-tls-ci-reneg-attack:

  • Use port 0 (OS-assigned available port) rather than common.PORT
  • Remove unnecessary boolean that causes race condition failure on some
    operating systems

Refactor that test and test-https-ci-reneg-attack:

  • Check all stderr, not just the chunk coming in now, in case it breaks
    up chunks in the middle of where the regexps are supposed to match.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: refactor test-*-ci-reneg-attack.js
68de8d7 
Refactor test-tls-ci-reneg-attack:

* Use port 0 (OS-assigned available port) rather than common.PORT
* Remove unnecessary boolean that causes race condition failure on some
  operating systems

Refactor that test and test-https-ci-reneg-attack:

* Check all stderr, not just the chunk coming in now, in case it breaks
  up chunks in the middle of where the regexps are supposed to match.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2355/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 23, 2019
@Trott Trott mentioned this pull request Jan 24, 2019
Closed
2 tasks
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@Trott
Copy link
Member Author

Trott commented Jan 25, 2019

Pummel tests are not run in CI, so lite CI should be sufficient. Might run a full pummel test suite if we get the pummel tests fixed (in other PRs)...

@Trott
Copy link
Member Author

Trott commented Jan 26, 2019

Closing in favor of #25700 and #25720. (Those both need reviews, so feel free to head over there to get them landed and get the pummel test suite green again.)

@Trott Trott closed this Jan 26, 2019
@Trott Trott deleted the update-tls-reneg branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @nodejs-github-bot @apapirovski