Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix 11.8.0 changelog #25705

Closed
wants to merge 1 commit into from
Closed

doc: fix 11.8.0 changelog #25705

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Problem with tool resulted in wrong commits being included

@MylesBorins
doc: fix 11.8.0 changelog
33eb732 
Problem with tool resulted in wrong commits being included
@nodejs-github-bot
Copy link
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2386/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2019
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2019
@MylesBorins
Copy link
Contributor Author

fast track?

cjihrig
cjihrig approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@richardlau
Copy link
Member

@MylesBorins I think all the REPLACEME's that were er, replaced in 641de82 should have been v11.8.0 and not v11.7.0. Do you want to fix them here along with the changelog, or leave for a separate PR?

@richardlau
Copy link
Member

(and given that I approved #25687 I'll take some of the blame here) 😅

@richardlau
Copy link
Member

I've raised #25709 to fix the docs metadata. Feel free to either fold it into this PR or process it on its own.

@richardlau richardlau mentioned this pull request Jan 25, 2019
Closed
3 tasks
@addaleax
Copy link
Member

Landed in 96731fc

@addaleax addaleax closed this Jan 25, 2019
addaleax pushed a commit that referenced this pull request Jan 25, 2019
@MylesBorins @addaleax
doc: fix 11.8.0 changelog
96731fc 
Problem with tool resulted in wrong commits being included

PR-URL: #25705
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@MylesBorins @addaleax
doc: fix 11.8.0 changelog
237ec39 
Problem with tool resulted in wrong commits being included

PR-URL: #25705
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @nodejs-github-bot @richardlau @addaleax @lpinca @cjihrig