Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-http-client-timeout-option-with-agent #25752

Closed
wants to merge 1 commit into from
Closed

test: refactor test-http-client-timeout-option-with-agent #25752

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 28, 2019

  • Switch from Date.now() to process.hrtime.bigint().
  • Move start time recording to before the request is created, not after.

Fixes: #25746

@devsnek @nodejs/http @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: refactor test-http-client-timeout-option-with-agent
106b37d 
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: nodejs#25746
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2413/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 28, 2019
@Trott Trott mentioned this pull request Jan 28, 2019
Closed
@Trott
Copy link
Member Author

Trott commented Jan 28, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20364/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@Trott
Copy link
Member Author

Trott commented Jan 30, 2019

Landed in b897704

Trott added a commit to Trott/io.js that referenced this pull request Jan 30, 2019
@Trott
test: refactor test-http-client-timeout-option-with-agent
b897704 
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: nodejs#25746

PR-URL: nodejs#25752
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott closed this Jan 30, 2019
targos pushed a commit that referenced this pull request Jan 30, 2019
@Trott @targos
test: refactor test-http-client-timeout-option-with-agent
1d1d3f5 
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: #25746

PR-URL: #25752
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the refactor-timeout-test branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent failure of test-http-client-timeout-option-with-agent
4 participants
@Trott @nodejs-github-bot @jasnell @devsnek