-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-trace-events-fs-sync as FLAKY #25899
Conversation
I'd like to fast track this. Please 👍 if you concur. |
We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay. |
If you do want to merge this, please add a reference to #25512 in the commit message. |
I'll verify that it solves the issue in a environment known to repro.
👍 with the magic of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although obviously even better if the proposed solution works and we don't have to mark this as flaky at all.
Superseded by #25896 |
Reopening since #25896 seems to be taking longer. Please 👍 for FT. |
CI: https://ci.nodejs.org/job/node-test-pull-request/20556/ |
Superseded by #25896 |
Refs: #25512
Flake frequency ebbs and flows but it's still a pain.
Marking as FLAKY until we solve the underling issue.
/CC @nodejs/testing @gireeshpunathil @addaleax
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes