Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps,util: V8: backport 74571c8 #25941

Closed
wants to merge 2 commits into from
Closed

Commits on Feb 16, 2019

  1. deps: V8: backport 74571c8

    Original commit message:
    
        Fix preview of set entries
    
        Set entries return an array with the value as first and second entry.
        As such these are considered key value pairs to align with maps
        entries iterator.
        So far the return value was identical to the values iterator and that
        is misleading.
    
        This also adds tests to verify the results and improves the coverage
        a tiny bit by testing different iterators.
    
        Refs: nodejs#24629
    
        R=yangguo@chromium.org
    
        Change-Id: I669a724bb4afaf5a713e468b1f51691d22c25253
        Reviewed-on: https://chromium-review.googlesource.com/c/1350790
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59311}
    
    Refs: v8/v8@74571c8
    BridgeAR committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    0a0ef6e View commit details
    Browse the repository at this point in the history
  2. util: update set iterator entries inspection

    The inspection output for Set#entries() was wrong so far as it did
    not return an array as it should have. That was a bug in V8 that is
    now fixed and the code in Node.js has to be updated accordingly.
    BridgeAR committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    305201b View commit details
    Browse the repository at this point in the history