Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: refactor for consistent style #25944

Closed
wants to merge 2 commits into from
Closed

benchmark: refactor for consistent style #25944

wants to merge 2 commits into from

Commits on Feb 5, 2019

  1. benchmark: refactor for consistent style 

    Code in benchmark directory sometimes uses `function () {}` for
anonymous callbacks and sometimes uses `() => {}`. Multi-line arrays
sometimes have a trailing comma and sometimes do not. Update to always
use arrow functions for anonymous callbacks and trailing commas for
multiline arrays.
    @Trott
    Trott committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    32d3174 View commit details
    Browse the repository at this point in the history

  2. tools: apply more stringent lint rules for benchmark code 

    All benchmark code uses trailing commas on multi-line arrays and arrow
functions for anonymous callbacks. Apply lint rules to that effect.
    @Trott
    Trott committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    0855569 View commit details
    Browse the repository at this point in the history