Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: use uv_getnameinfo() for socket endpoints #25962

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 6, 2019
src/node_report_utils.cc Outdated Show resolved Hide resolved
@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. report Issues and PRs related to process.report. labels Feb 6, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 7, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20645/

EDIT: CI was green.

PR-URL: nodejs#25962
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit 679c23f into nodejs:master Feb 8, 2019
@cjihrig cjihrig deleted the nameinfo branch February 8, 2019 16:35
addaleax pushed a commit that referenced this pull request Feb 8, 2019
PR-URL: #25962
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Feb 14, 2019
richardlau added a commit to richardlau/nodereport that referenced this pull request Feb 21, 2019
richardlau added a commit to richardlau/nodereport that referenced this pull request Mar 5, 2019
Ports fixes from core:
nodejs/node#25962
nodejs/node#26140

PR-URL: nodejs#123
Fixes: nodejs#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau added a commit to nodejs/node-report that referenced this pull request Mar 5, 2019
Ports fixes from core:
nodejs/node#25962
nodejs/node#26140

PR-URL: #123
Fixes: #120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants