Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: apply clang-tidy rule modernize-deprecated-headers #26159

Closed
wants to merge 1 commit into from
Closed

src: apply clang-tidy rule modernize-deprecated-headers #26159

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 17, 2019 •
edited
Loading

The rule link: https://clang.llvm.org/extra/clang-tidy/checks/modernize-deprecated-headers.html.

Summary

Some headers from C library were deprecated in C++ and are no longer welcome in C++ codebases. Some have no effect in C++. For more details refer to the C++ 14 Standard [depr.c.headers] section.

This check replaces C standard library headers with their C++ alternatives and removes redundant ones.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 17, 2019
@gengjiawen
Copy link
Member Author

Revert js_native_* seems they are used as c source file.

TimothyGu
TimothyGu reviewed Feb 17, 2019
View reviewed changes
src/node_os.cc Outdated Show resolved Hide resolved
@gengjiawen
Copy link
Member Author

gengjiawen commented Feb 18, 2019 •
edited
Loading

@addaleax @jasnell @cjihrig Can you review this ? thanks.

@danbev
Copy link
Contributor

danbev commented Feb 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20898/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@danbev
Copy link
Contributor

danbev commented Feb 22, 2019 •
edited
Loading

Re-run of failing node-test-commit-linuxone (✔️)

@gengjiawen
Copy link
Member Author

@danbev @addaleax Can you import the change ? thanks.

@danbev
Copy link
Contributor

danbev commented Feb 27, 2019

Landed in 8137668.

@danbev danbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
@gengjiawen @danbev
src: apply clang-tidy rule modernize-deprecated-headers
8137668 
PR-URL: #26159
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gengjiawen
Copy link
Member Author

thanks.

@gengjiawen gengjiawen deleted the clang-tidy-deprecated-headers branch February 27, 2019 07:40
@gengjiawen gengjiawen mentioned this pull request Feb 27, 2019
Merged
3 tasks
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen @addaleax
src: apply clang-tidy rule modernize-deprecated-headers
8b515b2 
PR-URL: #26159
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu left review comments

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @danbev @jasnell @TimothyGu @BridgeAR @nodejs-github-bot