test: remove duplicated buffer negative allocation test #26160

ZYSzys · 2019-02-17T11:44:36Z

The buffer negative allocation test test-buffer-negative-length.js is almost duplicated with test-buffer-no-negative-allocation.js.

node/test/parallel/test-buffer-negative-length.js

Lines 1 to 17 in 3fbf55a

    
           'use strict'; 
        
           const common = require('../common'); 
        
           const assert = require('assert'); 
        
           const SlowBuffer = require('buffer').SlowBuffer; 
        
           const bufferNegativeMsg = common.expectsError({ 
        
             code: 'ERR_INVALID_OPT_VALUE', 
        
             type: RangeError, 
        
             message: /^The value "[^"]*" is invalid for option "size"$/ 
        
           }, 5); 
        
           assert.throws(() => Buffer(-1).toString('utf8'), bufferNegativeMsg); 
        
           assert.throws(() => SlowBuffer(-1).toString('utf8'), bufferNegativeMsg); 
        
           assert.throws(() => Buffer.alloc(-1).toString('utf8'), bufferNegativeMsg); 
        
           assert.throws(() => Buffer.allocUnsafe(-1).toString('utf8'), bufferNegativeMsg); 
        
           assert.throws(() => Buffer.allocUnsafeSlow(-1).toString('utf8'), 
        
                         bufferNegativeMsg);

node/test/parallel/test-buffer-no-negative-allocation.js

Lines 1 to 28 in 3fbf55a

    
           'use strict'; 
        
           const common = require('../common'); 
        
           const assert = require('assert'); 
        
           const msg = common.expectsError({ 
        
             code: 'ERR_INVALID_OPT_VALUE', 
        
             type: RangeError, 
        
             message: /^The value "[^"]*" is invalid for option "size"$/ 
        
           }, 12); 
        
           // Test that negative Buffer length inputs throw errors. 
        
           assert.throws(() => Buffer(-Buffer.poolSize), msg); 
        
           assert.throws(() => Buffer(-100), msg); 
        
           assert.throws(() => Buffer(-1), msg); 
        
           assert.throws(() => Buffer.alloc(-Buffer.poolSize), msg); 
        
           assert.throws(() => Buffer.alloc(-100), msg); 
        
           assert.throws(() => Buffer.alloc(-1), msg); 
        
           assert.throws(() => Buffer.allocUnsafe(-Buffer.poolSize), msg); 
        
           assert.throws(() => Buffer.allocUnsafe(-100), msg); 
        
           assert.throws(() => Buffer.allocUnsafe(-1), msg); 
        
           assert.throws(() => Buffer.allocUnsafeSlow(-Buffer.poolSize), msg); 
        
           assert.throws(() => Buffer.allocUnsafeSlow(-100), msg); 
        
           assert.throws(() => Buffer.allocUnsafeSlow(-1), msg);

So remove test-buffer-negative-length.js and add SlowBuffer allocation test into test-buffer-no-negative-allocation.js.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Trott · 2019-02-17T14:46:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20832/ ✅

danbev · 2019-02-22T04:52:36Z

@ZYSzys Sorry about this, but would you be able to rebase this and fix the conflict and we can then re-run CI and get it merged. Thanks

ZYSzys · 2019-02-22T05:50:30Z

@danbev Done, thanks!

Trott · 2019-02-22T05:54:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20958/

addaleax · 2019-03-01T10:11:10Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21090/

addaleax · 2019-03-01T23:14:09Z

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25083/

BridgeAR · 2019-03-04T01:21:57Z

Landed in 6f6f6d4 🎉

PR-URL: nodejs#26160 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

PR-URL: #26160 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 17, 2019

addaleax approved these changes Feb 17, 2019

View reviewed changes

addaleax added the buffer Issues and PRs related to the buffer subsystem. label Feb 17, 2019

Trott approved these changes Feb 17, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2019

cjihrig approved these changes Feb 17, 2019

View reviewed changes

lpinca approved these changes Feb 18, 2019

View reviewed changes

BridgeAR approved these changes Feb 20, 2019

View reviewed changes

jasnell approved these changes Feb 21, 2019

View reviewed changes

test: remove duplicated buffer negative allocation test

283bb60

ZYSzys force-pushed the test-buffer-duplicated branch from a2135ba to 283bb60 Compare February 22, 2019 05:45

ChALkeR requested a review from starkwang March 1, 2019 23:20

ChALkeR approved these changes Mar 1, 2019

View reviewed changes

BridgeAR closed this Mar 4, 2019

ZYSzys deleted the test-buffer-duplicated branch March 4, 2019 02:44

BridgeAR mentioned this pull request Mar 4, 2019

v11.11.0 proposal #26322

Merged

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

beevelop mentioned this pull request May 29, 2019

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: remove duplicated buffer negative allocation test #26160

test: remove duplicated buffer negative allocation test #26160

ZYSzys commented Feb 17, 2019

Trott commented Feb 17, 2019 •

edited

Loading

danbev commented Feb 22, 2019

ZYSzys commented Feb 22, 2019

Trott commented Feb 22, 2019

addaleax commented Mar 1, 2019

addaleax commented Mar 1, 2019

BridgeAR commented Mar 4, 2019

	'use strict';

	const common = require('../common');
	const assert = require('assert');
	const SlowBuffer = require('buffer').SlowBuffer;

	const bufferNegativeMsg = common.expectsError({
	code: 'ERR_INVALID_OPT_VALUE',
	type: RangeError,
	message: /^The value "[^"]*" is invalid for option "size"$/
	}, 5);
	assert.throws(() => Buffer(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => SlowBuffer(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.alloc(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.allocUnsafe(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.allocUnsafeSlow(-1).toString('utf8'),
	bufferNegativeMsg);

test: remove duplicated buffer negative allocation test #26160

test: remove duplicated buffer negative allocation test #26160

Conversation

ZYSzys commented Feb 17, 2019

Checklist

Trott commented Feb 17, 2019 • edited Loading

danbev commented Feb 22, 2019

ZYSzys commented Feb 22, 2019

Trott commented Feb 22, 2019

addaleax commented Mar 1, 2019

addaleax commented Mar 1, 2019

BridgeAR commented Mar 4, 2019

Trott commented Feb 17, 2019 •

edited

Loading