Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase run time in test-worker-prof #26172

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.
@addaleax addaleax added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Feb 17, 2019
test/parallel/test-worker-prof.js Outdated Show resolved Hide resolved
@danbev
Copy link
Contributor

danbev commented Feb 18, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2019
@addaleax
Copy link
Member Author

Landed in fab0668

@addaleax addaleax closed this Feb 20, 2019
@addaleax addaleax deleted the worker-prof-increase branch February 20, 2019 15:47
addaleax added a commit that referenced this pull request Feb 20, 2019
This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.

PR-URL: #26172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Feb 21, 2019
This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.

PR-URL: #26172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.

Increasing the duration of the test should make it more reliable.

PR-URL: #26172
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants