Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: support name in validateTimerDuration() #26215

Merged
merged 1 commit into from
Feb 22, 2019
Merged

timers: support name in validateTimerDuration() #26215

merged 1 commit into from
Feb 22, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 20, 2019

As requested in #26214 (review)

Allow passing a name to validateTimerDuration() so that error messages can reflect the name of the thing being validated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2671/pipeline

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Feb 20, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 20, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20914/

EDIT: CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2019
@cjihrig
timers: support name in validateTimerDuration()
a1d05e4 
Allow passing a name to validateTimerDuration() so that error
messages can reflect the name of the thing being validated.

PR-URL: nodejs#26215
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit a1d05e4 into nodejs:master Feb 22, 2019
@cjihrig cjihrig deleted the val-timer-dur branch February 22, 2019 18:41
@addaleax
Copy link
Member

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR.

I assume it doesn’t really need to get backported because it’s preparation for a semver-major PR. Feel free to do so, though.

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @addaleax @apapirovski @jasnell @lpinca @BridgeAR