Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark,doc,lib,test: capitalize comments #26223

Closed
wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

This updates a lot of comments.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This updates a lot of comments.
@BridgeAR BridgeAR requested review from Trott and ryzokuken February 20, 2019 22:00
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 20, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, but are you willing to backport to the four current release branches (11, 10, 8, 6) so as to avoid endless merge conflicts going forward?

(I guess if churn is a concern, we can always try 45 or 49 instead of 40?)

@BridgeAR
Copy link
Member Author

@Trott yes, I am willing to do that. So far it seemed like the introduction of the rule itself did not cause any pain in backporting. It's probably because it's mostly just a single line in a comment and this can mostly be resolved automatically.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2019
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With in-passing nits, feel free to ignore or to address in a fixup commit/other PR.

test/parallel/test-stream-readable-event.js Outdated Show resolved Hide resolved
test/parallel/test-buffer-tostring-range.js Outdated Show resolved Hide resolved
vsemozhetbyt and others added 2 commits February 21, 2019 12:54
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BridgeAR 👍 👍

@BridgeAR
Copy link
Member Author

BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 28, 2019
This updates a lot of comments.

PR-URL: nodejs#26223
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in 9edce1e

@addaleax
Copy link
Member

addaleax commented Mar 1, 2019

This needs a manual backport for v11.x, which should probably happen soon, given that this changed 200 files.

It might also make sense to not land the bits that change the linter rules for the release branches, because that can get in the way of backporting this? (Maybe it could have been a separate commit? I know other people do it that way when modifying/adding/enabling linter rules.)

BridgeAR added a commit that referenced this pull request Mar 4, 2019
This updates a lot of comments.

PR-URL: #26223
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 4, 2019

I backported this directly to the staging branch.

@addaleax I'll separate the PRs in the future. That is indeed a good way of dealing with that. In this case I just ran make lint-js-fix after resolving the conflict (one line had to be fixed) and adding that to other cases (two other lines had to be changed).

@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
@BridgeAR BridgeAR deleted the capitalize-more branch January 20, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants