src: document DoWrite() usage expectations #26339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify how it must behave for both synchronous and asynchronous completion.
|
@sam-github sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Feb 28, 2019
addaleax
approved these changes
Feb 28, 2019
addaleax
added
the
author ready
cjihrig
approved these changes
Feb 28, 2019
|
re-ci: https://ci.nodejs.org/job/node-test-pull-request/21112/ It's just a header file comment, but a good build is hard to find. :-( |
|
re-ci: https://ci.nodejs.org/job/node-test-pull-request/21115/ windows vs2017 failed across the board, looks like remotes couldn't get connected to, but perhaps I misread the log files |
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25099/ |
BridgeAR
approved these changes
Mar 4, 2019
|
This should not require a full CI run as it's a doc only change. Therefore this should be good to land without making sure all platforms are green. |
|
Landed in 6593f77 |
sam-github
added a commit
that referenced
this pull request
Mar 4, 2019
Clarify how it must behave for both synchronous and asynchronous completion. PR-URL: #26339 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Clarify how it must behave for both synchronous and asynchronous completion. PR-URL: nodejs#26339 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify how it must behave for both synchronous and asynchronous
completion.
@addaleax @nodejs/streams This documents my understanding of the StreamResource::DoWrite() API expectations. TLS wasn't obeying these expecations, leading to wide-spread test suite failures during TLS1.3 development.
Checklist