Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable in node_http2.cc #26395

Closed
wants to merge 1 commit into from
Closed

src: remove unused variable in node_http2.cc #26395

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 2, 2019
@gengjiawen
Copy link
Member Author

@addaleax Can you review this pr ? Thanks.

@addaleax
Copy link
Member

addaleax commented Mar 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21185/

@danbev
Copy link
Contributor

danbev commented Mar 6, 2019

Landed in 3770ab9.

@danbev danbev closed this Mar 6, 2019
danbev pushed a commit that referenced this pull request Mar 6, 2019
@gengjiawen @danbev
src: remove unused variable in node_http2.cc
3770ab9 
PR-URL: #26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gengjiawen gengjiawen deleted the remove_unused_varibale_in_node_http2 branch March 6, 2019 09:14
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
src: remove unused variable in node_http2.cc
0c4e019 
PR-URL: nodejs#26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: remove unused variable in node_http2.cc
654f4d4 
PR-URL: #26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @addaleax @danbev @jasnell @nodejs-github-bot