Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: support RUSAGE_SELF stats on Windows #26406

Merged
merged 1 commit into from
Mar 5, 2019
Merged

report: support RUSAGE_SELF stats on Windows #26406

merged 1 commit into from
Mar 5, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 2, 2019

This commit adds support for the resourceUsage report section on Windows by using uv_getrusage() instead of getrusage().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2747/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 2, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Mar 2, 2019
@richardlau richardlau mentioned this pull request Mar 3, 2019
Closed
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 4, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/21181/

@cjihrig
report: support RUSAGE_SELF stats on Windows
84ebaaa 
This commit adds support for the resourceUsage report section
on Windows by using uv_getrusage() instead of getrusage().

PR-URL: nodejs#26406
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig cjihrig merged commit 84ebaaa into nodejs:master Mar 5, 2019
@cjihrig cjihrig deleted the rusage branch March 5, 2019 02:15
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@cjihrig @BridgeAR
report: support RUSAGE_SELF stats on Windows
0abb724 
This commit adds support for the resourceUsage report section
on Windows by using uv_getrusage() instead of getrusage().

PR-URL: nodejs#26406
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @richardlau