Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove unused variable in _http_server.js #26407

Closed
wants to merge 1 commit into from
Closed

http: remove unused variable in _http_server.js #26407

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 3, 2019 •
edited by lpinca
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 3, 2019
@lpinca
Copy link
Member

lpinca commented Mar 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21153/

@lpinca
Copy link
Member

lpinca commented Mar 3, 2019

Subsystem in commit message should be http:

@gengjiawen gengjiawen changed the title lib: remove unused variable in _http_server.js http: remove unused variable in _http_server.js Mar 3, 2019
@gengjiawen gengjiawen force-pushed the cleanup_http_server branch from 1921896 to 74e4711 Compare March 3, 2019 08:23
@gengjiawen
Copy link
Member Author

@lpinca Fixed :)

@lpinca
Copy link
Member

lpinca commented Mar 3, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21156/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21235/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21285/

@danbev
Copy link
Contributor

danbev commented Mar 7, 2019

Re-run of failing node-test-commit-arm-fanned (✔️)

@danbev
Copy link
Contributor

danbev commented Mar 7, 2019

Landed in 0fa1165.

@danbev danbev closed this Mar 7, 2019
danbev pushed a commit that referenced this pull request Mar 7, 2019
@gengjiawen @danbev
http: remove unused variable in _http_server.js
0fa1165 
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
http: remove unused variable in _http_server.js
5d2c522 
PR-URL: nodejs#26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
http: remove unused variable in _http_server.js
c661d8c 
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen @BethGriggs
http: remove unused variable in _http_server.js
378d4f1 
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @lpinca @BridgeAR @danbev @jasnell @tniessen @nodejs-github-bot