Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix wrong enum reference in node.cc #26430

Closed
wants to merge 1 commit into from
Closed

src: fix wrong enum reference in node.cc #26430

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

cc @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 4, 2019
@gengjiawen gengjiawen changed the title src: fix wrong enum reference in node.c src: fix wrong enum reference in node.cc Mar 4, 2019
@refack
Copy link
Contributor

refack commented Mar 4, 2019 •
edited
Loading

So it seems we need a test for this value. Or remove it since YAGNI.

CI: https://ci.nodejs.org/job/node-test-pull-request/21190/

@refack refack added the cli Issues and PRs related to the Node.js command line interface. label Mar 4, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in 9164543 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@gengjiawen @BridgeAR
src: fix wrong enum reference in node.cc
9164543 
PR-URL: nodejs#26430
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gengjiawen gengjiawen deleted the bugfix/wrong_variable branch March 9, 2019 04:04
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@gengjiawen @BridgeAR
src: fix wrong enum reference in node.cc
b435913 
PR-URL: nodejs#26430
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen @BridgeAR
src: fix wrong enum reference in node.cc
e21fa83 
PR-URL: #26430
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@refack refack refack approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @refack @BridgeAR @addaleax @cjihrig @richardlau @nodejs-github-bot