tools,doc: standardize on End-of-Life capitalization #26442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
richardlau
approved these changes
Mar 4, 2019
BridgeAR
approved these changes
Mar 4, 2019
BridgeAR
added
the
author ready
antsmartian
approved these changes
Mar 5, 2019
Trott
changed the title
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life".
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere.
|
Rebased due to a conflict with another commit. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2789/ |
|
Landed in d50fc51...9f2bde5 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 6, 2019
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life". PR-URL: nodejs#26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 6, 2019
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere. PR-URL: nodejs#26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life". PR-URL: nodejs#26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere. PR-URL: nodejs#26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life". PR-URL: #26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
This update includes an additional check for `End-of-life`. For consistency, we use `End-of-Life` everywhere. PR-URL: #26442 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes