src: add public API for linked bindings #26457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure `node::Init()` is called once, and execute `RunBootstrapping()` so that Node’s internals are ready when the cctests run.
(Re-?)add a public API for creating linked bindings (access to `NM_F_LINKED` as a constant was previously removed in d6ac8a4), and add a test for the functionality.
addaleax
added
semver-minor
nodejs-github-bot
added
build
bnoordhuis
approved these changes
Mar 5, 2019
bnoordhuis
reviewed
Mar 5, 2019
BridgeAR
added
the
author ready
joyeecheung
approved these changes
Mar 6, 2019
6 tasks
codebytere
approved these changes
Mar 8, 2019
jasnell
approved these changes
Mar 8, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 8, 2019
Make sure `node::Init()` is called once, and execute `RunBootstrapping()` so that Node’s internals are ready when the cctests run. PR-URL: nodejs#26457 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 8, 2019
(Re-?)add a public API for creating linked bindings (access to `NM_F_LINKED` as a constant was previously removed in d6ac8a4), and add a test for the functionality. PR-URL: nodejs#26457 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
Make sure `node::Init()` is called once, and execute `RunBootstrapping()` so that Node’s internals are ready when the cctests run. PR-URL: nodejs#26457 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
(Re-?)add a public API for creating linked bindings (access to `NM_F_LINKED` as a constant was previously removed in d6ac8a4), and add a test for the functionality. PR-URL: nodejs#26457 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: make cctest full Node.js environment
Make sure
node::Init()is called once, and executeRunBootstrapping()so that Node’s internals are readywhen the cctests run.
src: add public API for linked bindings
(Re-?)add a public API for creating linked bindings (access to
NM_F_LINKEDas a constant was previously removed in d6ac8a4),and add a test for the functionality.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes