Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit "Involving the TSC" #26481

Closed
wants to merge 2 commits into from
Closed

doc: edit "Involving the TSC" #26481

wants to merge 2 commits into from
+3 −4

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 6, 2019

Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

One thing I didn't do here but that I would definitely do if there is consensus: Remove mention of the tsc-review label and just tell people to @-mention the TSC. Sure, notification overload is a problem, but the tsc-review label always gets ignored. It's not even a placebo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: edit "Involving the TSC"
d02deda 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2790/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 6, 2019
richardlau
richardlau approved these changes Mar 6, 2019
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@richardlau @Trott
Update COLLABORATOR_GUIDE.md
89c4056 
Co-Authored-By: Trott <rtrott@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 6, 2019 •
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2791/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2019
@targos
Copy link
Member

targos commented Mar 7, 2019

Remove mention of the tsc-review label and just tell people to @-mention the TSC.

Yes, please!

@Trott
Copy link
Member Author

Trott commented Mar 8, 2019

Landed in ed465eb

@Trott Trott closed this Mar 8, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 8, 2019
@Trott
doc: edit "Involving the TSC"
ed465eb 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@Trott @BridgeAR
doc: edit "Involving the TSC"
cae30d9 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@Trott @BridgeAR
doc: edit "Involving the TSC"
5897bf4 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: #26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott @BethGriggs
doc: edit "Involving the TSC"
11d163b 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: #26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the involving-tsc branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @targos @jasnell @cjihrig @hiroppy @richardlau @BethGriggs @BridgeAR