src: refactor coverage connection #26513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
addaleax
approved these changes
Mar 8, 2019
gengjiawen
reviewed
Mar 8, 2019
| "Sending Profiler.startPreciseCoverage\n"); | ||
| Isolate* isolate = this->env()->isolate(); | ||
| Local<String> enable = FIXED_ONE_BYTE_STRING( | ||
| isolate, "{\"id\": 1, \"method\": \"Profiler.enable\"}"); |
gengjiawen
reviewed
Mar 8, 2019
gengjiawen
reviewed
Mar 8, 2019
bcoe
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
This looks reasonable to me 👍 It's nice to be able to remove the confusing disableAllAsyncHooks methods.
Let's just make sure we run the coverage CI against this before we land? @mhdawson how far did we get on making this run as part of the smoke testing process?
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage.
joyeecheung
force-pushed
the
refactor-coverage
branch
from
92ffa3b
to
a709987
Compare
|
Rebased and addressed reviews. CI: https://ci.nodejs.org/job/node-test-pull-request/21434/ @gengjiawen Regarding raw strings: I have no idea why but it looks like neither we nor non-test V8 code use those, so I'd prefer leaving that out of this PR, in case there's any weird compiler support oddities. Feel free to open a separate PR to update those. |
|
I don't think there is a job to run the coverage CI against a PR. I do get a successful run locally though. If this comes back breaking the coverage, we can just revert. |
|
Landed in 963ee0b...eb0bf8d |
joyeecheung
added a commit
that referenced
this pull request
Mar 11, 2019
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Mar 11, 2019
PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
3 tasks
|
This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly. |
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: refactor coverage connection
to be inside the callback to silence potential JSON or write
errors.
message callback since it does not actually need async hook
handling. This way we no longer needs to disable the async
hooks when writing the coverage results.
lib/internal/coverage-gen/with_profiler.jstolib/internal/profiler.jsbecause it is now the only wayto generate coverage.
test: show stderr on v8 coverage test failures
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes