Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits in writing-tests.md #26543

Closed
wants to merge 1 commit into from
Closed

doc: fix nits in writing-tests.md #26543

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Correct a typo.
  • Normalize spaces.
  • Split a paragraph with different topics.

* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 9, 2019
@vsemozhetbyt vsemozhetbyt added the test Issues and PRs related to the tests. label Mar 9, 2019
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 9, 2019
@vsemozhetbyt
Copy link
Contributor Author

Landed in 4e9dc31
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-test-console branch March 9, 2019 12:18
vsemozhetbyt added a commit that referenced this pull request Mar 9, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants