modules: do not share the internal require function with public loaders #26549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
joyeecheung
commented
Mar 9, 2019
|
|
||
| const fn = compileFunction(id); | ||
| fn(this.exports, requireFn, this, process, internalBinding, primordials); | ||
|
|
||
| if (experimentalModules && this.canBeRequiredByUsers) { |
There was a problem hiding this comment.
Note that since we no longer hits canBeRequiredByUsers for the internal require, we should be able to remove the immediate dependency of exposeInternals in loaders.js in a future PR, and get the value of that option from C++ later when necessary - only after bootstrap is complete, of course.
jasnell
approved these changes
Mar 10, 2019
joyeecheung
force-pushed
the
move-proxify
branch
from
c880e16 to
e36dc52
Compare
This patch removes `NativeModule.require` and `NativeModule.requireWithFallbackInDeps`. The public loaders now have to use a special method `NativeModule.prototype.compileForPublicLoader()` to compile native modules. In addition this patch moves the decisions of proxifying exports and throwing unknown builtin errors entirely to public loaders, and skip those during internal use - therefore `loaders.js`, which is compiled during bootstrap, no longer needs to be aware of the value of `--experimental-modules`.
joyeecheung
force-pushed
the
move-proxify
branch
from
e36dc52 to
df42c60
Compare
|
Landed in 84156cf |
joyeecheung
added a commit
that referenced
this pull request
Mar 18, 2019
This patch removes `NativeModule.require` and `NativeModule.requireWithFallbackInDeps`. The public loaders now have to use a special method `NativeModule.prototype.compileForPublicLoader()` to compile native modules. In addition this patch moves the decisions of proxifying exports and throwing unknown builtin errors entirely to public loaders, and skip those during internal use - therefore `loaders.js`, which is compiled during bootstrap, no longer needs to be aware of the value of `--experimental-modules`. PR-URL: #26549 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
This patch removes `NativeModule.require` and `NativeModule.requireWithFallbackInDeps`. The public loaders now have to use a special method `NativeModule.prototype.compileForPublicLoader()` to compile native modules. In addition this patch moves the decisions of proxifying exports and throwing unknown builtin errors entirely to public loaders, and skip those during internal use - therefore `loaders.js`, which is compiled during bootstrap, no longer needs to be aware of the value of `--experimental-modules`. PR-URL: #26549 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
NativeModule.requireandNativeModule.requireWithFallbackInDeps. The public loaders nowhave to use a special method
NativeModule.prototype.compileForPublicLoader()to compile nativemodules. In addition this patch moves the decisions of proxifying
exports and throwing unknown builtin errors entirely to public
loaders, and skip those during internal use - therefore
loaders.js,which is compiled during bootstrap, no longer needs to be aware of
the value of
--experimental-modules.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes