Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #26546 #26552

Closed
wants to merge 3 commits into from
Closed

Fixes: #26546 #26552

wants to merge 3 commits into from

Conversation

micheleriva
Copy link

@micheleriva micheleriva commented Mar 9, 2019 •
edited
Loading

Fixes:

  • lib/_http_agent.js#L25
  • lib/_http_common.js#L39
  • lib/_http_outgoing.js#L26
  • lib/_http_server.js#L24
  • lib/_tls_wrap.js#L30 *
  • lib/assert.js#L32
  • lib/child_process.js#L24
  • lib/dgram.js#L48
  • lib/domain.js#L29 *
  • lib/https.js#L28
  • lib/inspector.js#L19
  • lib/internal/assert/assertion_error.js#L3
  • lib/internal/bootstrap/node.js#L192 *
  • lib/internal/child_process.js#L21
  • lib/internal/console/constructor.js#L18 *
  • lib/internal/encoding.js#L330
  • not clear what to do
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 9, 2019
@micheleriva micheleriva changed the title Fixes: https://github.com/nodejs/node/issues/26546 Fixes: #26546 Mar 9, 2019
ZYSzys
ZYSzys reviewed Mar 9, 2019
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emmm...the http part maybe conflict with #26548.

lib/https.js Show resolved Hide resolved
@micheleriva micheleriva mentioned this pull request Mar 10, 2019
Closed
@micheleriva
Copy link
Author

Closed in favour of single PRs as commented on #26546

@micheleriva micheleriva deleted the issue-26546 branch March 10, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys left review comments

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micheleriva @ZYSzys @nodejs-github-bot