Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-worker-prof as Flaky on ARM #26557

Merged
merged 1 commit into from
Mar 10, 2019
Merged

test: mark test-worker-prof as Flaky on ARM #26557

merged 1 commit into from
Mar 10, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 10, 2019 •
edited
Loading

Refs: #26401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2845/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 10, 2019
@refack refack requested review from Trott and addaleax March 10, 2019 02:07
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 10, 2019
@refack
Copy link
Contributor Author

refack commented Mar 10, 2019 •
edited
Loading

If this passes CI, I move we fast-tack this.
CI: https://ci.nodejs.org/job/node-test-pull-request/21384/

@refack
Copy link
Contributor Author

refack commented Mar 10, 2019

/CC @nodejs/testing

@refack refack mentioned this pull request Mar 10, 2019
Closed
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@refack
test: mark test-worker-prof as Flaky on ARM
8d665c0 
PR-URL: nodejs#26557
Refs: nodejs#26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack force-pushed the flake-test-worker-prof branch from 8a690b4 to 8d665c0 Compare March 10, 2019 14:20
@refack refack merged commit 8d665c0 into nodejs:master Mar 10, 2019
@refack refack deleted the flake-test-worker-prof branch March 10, 2019 14:22
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
test: mark test-worker-prof as Flaky on ARM
677c43d 
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@refack @BridgeAR
test: mark test-worker-prof as Flaky on ARM
cc32461 
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack @BridgeAR
test: mark test-worker-prof as Flaky on ARM
bf78365 
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@refack @BethGriggs
test: mark test-worker-prof as Flaky on ARM
f0acdfd 
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @nodejs-github-bot @Trott @gireeshpunathil @BridgeAR