-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add Note of options.stdio into child_process #26604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing file descriptors works fine on Windows, its just sockets that are not supported.
But in that case it’s probably not right to put it just under this particular type of option? Passing in a |
doc/api/child_process.md
Outdated
@@ -637,7 +637,8 @@ pipes between the parent and child. The value is one of the following: | |||
occurred). | |||
6. Positive integer - The integer value is interpreted as a file descriptor | |||
that is currently open in the parent process. It is shared with the child | |||
process, similar to how {Stream} objects can be shared. | |||
process, similar to how {Stream} objects can be shared. Passing sockets | |||
does not supported on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not supported on Windows. | |
is not supported on Windows. |
Windows allow named pipe. I think Passing in a It's valid on Windows.
|
Landed in e08ac04. |
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: nodejs#26604 Refs: nodejs#22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
PR-URL: #26604 Refs: #22892 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
add Note of
options.stdio
into child_process.Ref: #22892 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes