process: set the trace category update handler during bootstrap #26605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
commented
Mar 12, 2019
jasnell
approved these changes
Mar 12, 2019
addaleax
approved these changes
Mar 12, 2019
addaleax
reviewed
Mar 12, 2019
joyeecheung
force-pushed
the
set-trace
branch
2 times, most recently
from
df2a5a1 to
437d9cd
Compare
|
Fixed the test description and the commit message. |
- Add descriptions - Filter out the relevant traces for testing, ignore the irrelevant ones.
Set the trace category update handler during bootstrap, but delay the initial invocation of it until pre-execution. In addition, do not serialize the `node.async_hooks` category state when loading the trace_event binding during bootstrap, since it depends on run time states (e.g. CLI flags). Instead, use the `isTraceCategoryEnabled` v8 intrinsics to query that value during pre-execution.
joyeecheung
added
the
author ready
|
Landed in d398e89...a91d36f |
joyeecheung
added a commit
that referenced
this pull request
Mar 18, 2019
- Add descriptions - Filter out the relevant traces for testing, ignore the irrelevant ones. PR-URL: #26605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung
added a commit
that referenced
this pull request
Mar 18, 2019
Set the trace category update handler during bootstrap, but delay the initial invocation of it until pre-execution. In addition, do not serialize the `node.async_hooks` category state when loading the trace_event binding during bootstrap, since it depends on run time states (e.g. CLI flags). Instead, use the `isTraceCategoryEnabled` v8 intrinsics to query that value during pre-execution. PR-URL: #26605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
- Add descriptions - Filter out the relevant traces for testing, ignore the irrelevant ones. PR-URL: #26605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Set the trace category update handler during bootstrap, but delay the initial invocation of it until pre-execution. In addition, do not serialize the `node.async_hooks` category state when loading the trace_event binding during bootstrap, since it depends on run time states (e.g. CLI flags). Instead, use the `isTraceCategoryEnabled` v8 intrinsics to query that value during pre-execution. PR-URL: #26605 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: refactor trace event category tests
ones.
process: set the trace category update handler during bootstrap
Set the trace category update handler during bootstrap, but delay
the initial invocation of it until pre-execution. In addition, do
not serialize the
node.async_hookscategory state when loadingthe trace_event binding during bootstrap, since it depends on
run time states (e.g. CLI flags). Instead, use the
isTraceCategoryEnabledv8 intrinsics to query that value duringpre-execution.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes