Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] src: apply clang-tidy rule modernize-make-unique #26651

Closed
wants to merge 1 commit into from
Closed

[v11.x backport] src: apply clang-tidy rule modernize-make-unique #26651

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 14, 2019

PR-URL: #26493
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2902/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v11.x labels Mar 14, 2019
@refack refack mentioned this pull request Mar 14, 2019
Closed
2 tasks
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21525/

@BridgeAR BridgeAR force-pushed the v11.x-staging branch 3 times, most recently from 2beeaf8 to f82e07b Compare March 14, 2019 10:24
@BridgeAR
Copy link
Member

@refack this needs a rebase.

@refack refack force-pushed the backport-26493-to-v11.x branch from 8078370 to 021ea77 Compare March 14, 2019 14:29
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21543/ (ATM shared-openSSL-1.1.0 expected to fail)

@gengjiawen @refack
src: apply clang-tidy rule modernize-make-unique
9b73f1d 
PR-URL: nodejs#26493
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@refack refack force-pushed the backport-26493-to-v11.x branch from 021ea77 to 9b73f1d Compare March 14, 2019 16:45
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/21549/

@targos
Copy link
Member

targos commented Mar 28, 2019

The original PR landed cleanly after applying other backports/changes.

@targos targos closed this Mar 28, 2019
@refack refack deleted the backport-26493-to-v11.x branch April 14, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @nodejs-github-bot @BridgeAR @targos @gengjiawen