Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Gireesh to TSC #26657

Closed
wants to merge 1 commit into from
Closed

doc: add Gireesh to TSC #26657

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 14, 2019

TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: #26186

@gireeshpunathil

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: add Gireesh to TSC
63a9b71 
TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: nodejs#26186
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 14, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2904/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2019
@gireeshpunathil
Copy link
Member

thanks @Trott ! I am not sure if there is any actionable on my part on this PR / any onboarding activity; pls advise!

oliver-gomes
oliver-gomes approved these changes Mar 14, 2019
View reviewed changes
Copy link

@oliver-gomes oliver-gomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@Trott
Copy link
Member Author

Trott commented Mar 14, 2019

thanks @Trott ! I am not sure if there is any actionable on my part on this PR / any onboarding activity; pls advise!

You can review the PR (confirm the information and formatting is correct) just like any other Collaborator, but other than that, nothing actionable on this PR.

@Trott
Copy link
Member Author

Trott commented Mar 14, 2019

Seems no reason to leave this open 48 hours. 👍 here to fast-track.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 14, 2019
@richardlau richardlau mentioned this pull request Mar 14, 2019
Closed
3 tasks
mhdawson
mhdawson approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Mar 14, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 14, 2019
@Trott
doc: add Gireesh to TSC
8549ac0 
TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: nodejs#26186

PR-URL: nodejs#26657
Fixes: nodejs#26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 14, 2019

Landed in 8549ac0

🎉

@Trott Trott closed this Mar 14, 2019
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@Trott @targos
doc: add Gireesh to TSC
4bb8f6e 
TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: nodejs#26186

PR-URL: nodejs#26657
Fixes: nodejs#26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Trott @targos
doc: add Gireesh to TSC
3b471db 
TSC voted in Gireesh today. Add him to the TSC list in the README.

Closes: #26186

PR-URL: #26657
Fixes: #26186
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@Trott Trott deleted the add-gireesh-to-tsc branch January 13, 2022 22:51
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-gomes oliver-gomes oliver-gomes approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating Gireesh Punathil (@gireeshpunathil) to the TSC