Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use deleted function instead of private function in class AsyncWrap #26703

Closed
wants to merge 1 commit into from
Closed

src: use deleted function instead of private function in class AsyncWrap #26703

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 16, 2019
@addaleax
Copy link
Member

Could this be made part of #26634, given that it is a very similar kind of change?

@gengjiawen
Copy link
Member Author

Could this be made part of #26634, given that it is a very similar kind of change?

#26634 is focus on macro DISALLOW_COPY_AND_ASSIGN.
But I don't hold strong opinion on this, second thought ?

@refack
Copy link
Contributor

refack commented Mar 16, 2019 •
edited
Loading

I agree with @addaleax. This makes a lot of sense as part of #26634. Unless you find a bunch of these old "delete by unimplemented private" kludges put add to this.

@gengjiawen
Copy link
Member Author

Should I keep this a single commit or squash it to one ?

@gengjiawen
Copy link
Member Author

cherry-pick to #26634

@gengjiawen gengjiawen closed this Mar 17, 2019
@gengjiawen gengjiawen deleted the refactor_async_wrap_ctor branch March 17, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @addaleax @refack @nodejs-github-bot