Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-heapdump-worker #26713

Closed
wants to merge 1 commit into from
Closed

test: fix test-heapdump-worker #26713

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This test was broken by d35af56.

Refs: #21283
Fixes: #26712

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: fix test-heapdump-worker
0dad72f 
This test was broken by d35af56.

Refs: nodejs#21283
Fixes: nodejs#26712
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2941/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 17, 2019
@addaleax addaleax added worker Issues and PRs related to Worker support. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 17, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 17, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21608/
Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5417/

Please 👍 this comment to approve fast-tracking, it unbreaks a test.

@addaleax addaleax mentioned this pull request Mar 17, 2019
Closed
@richardlau
Copy link
Member

Landed in ed60e86.

@richardlau richardlau closed this Mar 18, 2019
richardlau pushed a commit that referenced this pull request Mar 18, 2019
@addaleax @richardlau
test: fix test-heapdump-worker
ed60e86 
This test was broken by d35af56.

Refs: #21283
Fixes: #26712

PR-URL: #26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@addaleax @targos
test: fix test-heapdump-worker
6239913 
This test was broken by d35af56.

Refs: nodejs#21283
Fixes: nodejs#26712

PR-URL: nodejs#26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@addaleax @targos
test: fix test-heapdump-worker
c65ff3d 
This test was broken by d35af56.

Refs: #21283
Fixes: #26712

PR-URL: #26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky pummel/test-heapdump-worker
5 participants
@addaleax @nodejs-github-bot @richardlau @cjihrig @gireeshpunathil