-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update configure for Node.js 12 #26719
Conversation
Note that this check is a warning and doesn't prevent you attempting to use older compilers. |
If this is just a warning, perhaps the language in the commit message is a bit too strong? |
IMHO that makes this not semver-major, just a "don't land on X" |
I agree. #26714 being semver-major is enough |
Updated the commit message and clang level. PTAL. New CI: https://ci.nodejs.org/job/node-test-pull-request/21714/ (✔️) |
I think it's good to capture the state of things with this PR right now. |
Update supported level of gcc to 6.3.0 and clang to 8.0.0. Refs: nodejs#26714 PR-URL: nodejs#26719 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in 41ba699. |
Refs: #26714
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes