Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do not make Resize(0)’d buffers base nullptr #26731

Closed
wants to merge 1 commit into from
Closed

src: do not make Resize(0)’d buffers base nullptr #26731

wants to merge 1 commit into from

Commits on Mar 18, 2019

  1. src: do not make Resize(0)’d buffers base nullptr 

    This fixes issues in which APIs that accept pointers created this way
treat `nullptr` and a zero-length buffer differently.
We already do something similar for our `Malloc()` implementation.

Fixes: nodejs#26514
    @addaleax
    addaleax committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    7e27948 View commit details
    Browse the repository at this point in the history