Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: initialize worker's stack_base_ field #26739

Closed
wants to merge 1 commit into from
Closed

src: initialize worker's stack_base_ field #26739

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 18, 2019

Coverity was complaining that this field was not initialized.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
src: initialize worker's stack_base_ field
ba71de7 
Coverity was complaining that this field was not initialized.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 18, 2019
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2964/pipeline

@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21716/

@danbev
Copy link
Contributor

danbev commented Mar 22, 2019 •
edited
Loading

Re-run of failing node-test-commit-arm-fanned (✔️)

@danbev
Copy link
Contributor

danbev commented Mar 22, 2019

Landed in 76387c1.

@danbev danbev closed this Mar 22, 2019
danbev pushed a commit that referenced this pull request Mar 22, 2019
@cjihrig @danbev
src: initialize worker's stack_base_ field
76387c1 
Coverity was complaining that this field was not initialized.

PR-URL: #26739
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Mar 22, 2019
Closed
Closed
@cjihrig cjihrig deleted the coverity branch March 25, 2019 22:05
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@cjihrig @targos
src: initialize worker's stack_base_ field
fd2d76c 
Coverity was complaining that this field was not initialized.

PR-URL: nodejs#26739
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@cjihrig @targos
src: initialize worker's stack_base_ field
79d6895 
Coverity was complaining that this field was not initialized.

PR-URL: #26739
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @danbev @jasnell @ZYSzys