Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 5.15.3 #26746

Merged
merged 1 commit into from
Mar 23, 2019
Merged

tools: update ESLint to 5.15.3 #26746

merged 1 commit into from
Mar 23, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 18, 2019

Update ESLint to 5.15.3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2969/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 18, 2019
Trott
Trott approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@danbev
Copy link
Contributor

danbev commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21715/

@cjihrig
tools: update ESLint to 5.15.3
2b89ac6 
Update ESLint to 5.15.3

PR-URL: nodejs#26746
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit 2b89ac6 into nodejs:master Mar 23, 2019
@cjihrig cjihrig deleted the eslint branch March 23, 2019 16:04
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@cjihrig @targos
tools: update ESLint to 5.15.3
9ea53c8 
Update ESLint to 5.15.3

PR-URL: nodejs#26746
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@cjihrig @targos
tools: update ESLint to 5.15.3
08383a7 
Update ESLint to 5.15.3

PR-URL: #26746
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @danbev @Trott @richardlau @ZYSzys