console: fix trace function #26764
Closed
console: fix trace function #26764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent refactoring made the slight mistake of calling `trace()` instead of `this.trace()`. Fixes: nodejs#26763
nodejs-github-bot
added
the
console
richardlau
approved these changes
Mar 19, 2019
devsnek
approved these changes
Mar 19, 2019
ZYSzys
approved these changes
Mar 19, 2019
starkwang
approved these changes
Mar 19, 2019
lpinca
approved these changes
Mar 19, 2019
antsmartian
approved these changes
Mar 19, 2019
BridgeAR
added
the
author ready
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 21, 2019
A recent refactoring made the slight mistake of calling `trace()` instead of `this.trace()`. PR-URL: nodejs#26764 Fixes: nodejs#26763 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
Landed in ab3f7af. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
A recent refactoring made the slight mistake of calling `trace()` instead of `this.trace()`. PR-URL: nodejs#26764 Fixes: nodejs#26763 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
A recent refactoring made the slight mistake of calling `trace()` instead of `this.trace()`. PR-URL: #26764 Fixes: #26763 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent refactoring made the slight mistake of using
trace()instead of
this.trace().Fixes: #26763
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes