Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove usage of require('util') #26777

Closed
wants to merge 1 commit into from
Closed

lib: remove usage of require('util') #26777

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 19, 2019

Remove usage of public require('util').inspect,
require('util').formatWithOptions and require('util').types.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
lib: remove usage of require('util')
4a5c9a6 
Remove usage of public `require('util').inspect` and 
`require('util').formatWithOptions`.

Refs: nodejs#26546
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Mar 19, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21756/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21786/

@BridgeAR
Copy link
Member

Landed in cf1b9d3 🎉

@BridgeAR BridgeAR closed this Mar 24, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 24, 2019
@dnlup @BridgeAR
lib: remove usage of require('util')
cf1b9d3 
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@dnlup @targos
lib: remove usage of require('util')
5aa4259 
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@dnlup @targos
lib: remove usage of require('util')
64a9229 
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: #26777
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
@dnlup dnlup deleted the util_internal_console_constructor branch January 10, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnlup @BridgeAR @jasnell @nodejs-github-bot